docs: Ambient ERD and RBAC Software Factory proposal#759
Open
markturansky wants to merge 1 commit intoambient-code:mainfrom
Open
docs: Ambient ERD and RBAC Software Factory proposal#759markturansky wants to merge 1 commit intoambient-code:mainfrom
markturansky wants to merge 1 commit intoambient-code:mainfrom
Conversation
- docs/internal/design/ambient-erd.md: canonical Mermaid ERD of the current ambient-api-server data model (User, Project, ProjectSettings, Session) derived directly from openapi.yaml. This document is the living spec — future Kind additions are proposed as diffs against it. - docs/internal/proposals/rbac-rolebinding.md: proposal to add first-class RBAC to the API using the Software Factory pattern. Permissions and Roles are static Go (type-safe, TDD-friendly); RoleBinding is the only new database-backed Kind (generated by TRex). Three binding scopes: global, workspace, session. Enforced entirely within ambient-api-server — no Kubernetes RBAC sync required. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This feature falls into what we might consider a "core" feature of ACP. I propose we start picking up spec-kit opportunistically for "core" work. This could be the first one to do it. We have to agree together. I added a note for standup. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: RHOAIENG-51884
Summary
docs/internal/design/ambient-erd.md— canonical Mermaid ERD of the current Ambient data model, derived directly fromopenapi.yaml. This is the living spec: future Kind additions are proposed as diffs against it.docs/internal/proposals/rbac-rolebinding.md— proposal to add first-class RBAC using the Software Factory pattern.Design Decisions
Static vs Dynamic:
PermissionandRoleare static Go constants/structs — compile-time safety, TDD-friendly, no DB tableRoleBindingis the only new database-backed Kind (one TRex generator invocation)Three binding scopes:
project_id = null, session_id = null)project_id = <id>, session_id = null)project_id = <id>, session_id = <id>)API-native enforcement — permission middleware in
ambient-api-serveronly; no Kubernetes RBAC sync required.How to use these docs
ambient-erd.mdas the current state specrbac-rolebinding.mdas the proposed diff (addsRoleBindingKind, removesgroup_accessJSON blob)ambient-erd.mdto includeRoleBindingand the Software Factory executes the cascade🤖 Generated with Claude Code