Review Queue — ambient-code/platform
Date: 2026-03-13
Open PRs: 52 | Ready for Review: 6 | In Queue: 28
At a Glance
This review queue prioritizes PRs by readiness: bug fixes first, then clean PRs (no blockers), then features, ordered by size and recency. The milestone contains 28 PRs that are ready or almost ready for human review.
Top priorities:
- #906 — fix: remove stale sections from manifests README (bug-fix, clean)
- #895 — fix(RHOAIENG-52949): scope session listing by X-Ambient-Project header (bug-fix, clean)
- #774 — ci(deps): bump actions/cache from 4 to 5 (chore, clean)
Ready for Review (6)
| # | PR | Type | Author | Size | Updated | Action Needed |
|---|---|---|---|---|---|---|
| 1 | #906 — fix: remove stale sections from manifests README | bug-fix | @ktdreyer | S | Mar 12 | Human approval |
| 2 | #895 — fix(RHOAIENG-52949): scope session listing by X-Ambient-Project header | bug-fix | @maskarb | M | Mar 12 | Human approval |
| 3 | #774 — ci(deps): bump actions/cache from 4 to 5 | chore | @dependabot | S | Mar 13 | Human approval |
| 4 | #855 — feat: Add session control endpoints to public API | feature | @tiwillia | XL | Mar 12 | Human review (large feature) |
| 5 | #759 — docs: Ambient ERD and RBAC Software Factory proposal | docs | @markturansky | L | Mar 12 | Human approval (design proposal) |
| 6 | #758 — docs: Add React state stability patterns and theme creation guidelines | docs | @ambient-code | M | Mar 12 | Team discussion requested by @Gkrumbach07 |
Almost Ready (6)
#773 — ci(deps): bump actions/setup-python from 5 to 6
chore · @dependabot · S · Mar 13
- All previous blockers resolved
- 5 CI checks passing, 2 checks in progress (End-to-End Tests, test-local-dev-simulation)
- No merge conflicts
- Simple dependency bump
Needs: Wait for 2 in-progress CI checks to complete
#829 — fix(frontend): show friendly message for binary files instead of garbled text
bug-fix · @jeremyeder · M · Mar 12
- CI is green, no merge conflicts
- Bot reviews identified 3 minor code quality improvements (SVG classification, unused dependency, redundant config)
- Stale bot comment from Mar 10 incorrectly flagged everything as FAIL
Needs: Author should address the 3 minor bot review findings for code quality
#807 — feat(public-api): complete session API surface for mcp-acp integration
feature · @adalton · L · Mar 12
- CI passing (32/32), no merge conflicts
- Author addressed most bot feedback through 6+ iterations
- Latest bot review (Mar 9) still identifies 2 Major issues: hardcoded pod-naming constant needed, query parameter allow lists at security boundary
Needs: Address 2 remaining Major issues, then ping @jeremyeder for re-review and approval
#793 — RHOAIENG-50709: add ADR for CI/CD on firewalled clusters
docs · @ktdreyer · M · Mar 12
- CI passing, no merge conflicts
- Two recent coderabbitai suggestions (Mar 12): documenting security guardrails for runner access and making health monitoring mandatory
- Minor factual error: "Gemini 3 Pro" model name doesn't exist
Needs: Address coderabbitai inline comments and correct AI model name
#820 — feat(skill): add port-forward manager to dev-cluster skill
feature · @jeremyeder · M · Mar 11
- CI passing, mergeable status UNKNOWN (GitHub hasn't computed yet)
- Bot flagged merge conflicts on Mar 5 and Mar 11, but current status shows UNKNOWN not CONFLICTING
Needs: Verify merge status and rebase if needed
#845 — chore(runner): bump all dependencies, upgrade to UBI 10 / Python 3.12
chore · @jeremyeder · L · Mar 12
- CI passing (29/29), no merge conflicts
- @jeremyeder raised a security concern (Mar 7) about CLI flags potentially defeating security controls
- No commits since the concern was raised
Needs: Address or acknowledge security concern about agent options
Remaining Blocked (35)
| # | PR | Type | Author | Updated | Issue |
|---|---|---|---|---|---|
| 1 | #870 — chore(ci): remove stale public-api from build and deploy workflows | bug-fix | @maskarb | Mar 12 | - @markturansky hold request (waiting for new API) |
| 2 | #744 — feat(ci): add workflow_dispatch to Amber auto review | feature | @jeremyeder | Mar 12 | - Critical script injection vulnerability |
| 3 | #604 — feat(operator): externalize session container resource limits to ConfigMap | feature | @jeremyeder | Mar 12 | - resource.MustParse() panic risk violates standards |
| 4 | #697 — feat: add session labels with editor and filtering | feature | @jeremyeder | Mar 12 | - PatchSession validation gap - Dead code components |
| 5 | #656 — perf(operator): parallelize secret reads, remove monitorPod goroutine | feature | @syntaxsdev | Mar 12 | - Author hold request + 22 days inactive - Critical inactivity auto-stop regression |
| 6 | #618 — fix: state-sync arm64 compatibility across CI and local dev | bug-fix | @jeremyeder | Mar 12 | - Merge conflicts (CONFLICTING) |
| 7 | #663 — fix: update oauth-proxy image to resolve ImagePullBackOff | bug-fix | @jeremyeder | Mar 12 | - 2 CI failures - Merge conflicts - OTel config breakage |
| 8 | #662 — Claude/fix UI performance | bug-fix | @jeremyeder | Mar 12 | - 2 CI failures - Merge conflicts |
| 9 | #849 — fix(workflow): render startup greeting client-side with race condition fixes | bug-fix | @jeremyeder | Mar 12 | - Merge conflicts (CONFLICTING) |
| 10 | #805 — feat(RHOAIENG-50753): add LDAP user and group autocomplete for workspace sharing | feature | @mprpic | Mar 12 | - Merge conflicts (CONFLICTING) |
| 11 | #815 — feat: add ambient-control-plane with Kubernetes reconcilers and gRPC watch | feature | @markturansky | Mar 12 | - 2 CI failures - Merge conflicts - Missing OwnerReferences |
| 12 | #640 — WIP: Feat/Frontend to consume new v2 API | feature | @markturansky | Mar 12 | - 4 CI failures - Security/auth issues - Still marked WIP |
| 13 | #866 — WIP: feat(api-server): session messages, agents, roles, RBAC | feature | @markturansky | Mar 12 | - 2 CI failures - RBAC security gap - Still marked WIP |
| 14 | #791 — [Amber] Fix: [Amber] docs/internal/adr/README.md table is out of date | docs | @github-actions | Mar 12 | - CHANGES_REQUESTED from @ktdreyer - Went wrong direction |
| 15 | #832 — docs: add feature flag fail-modes reference and consolidate ADRs | docs | @maskarb | Mar 12 | - File overlap with PR #791 |
| 16 | #717 — Add workflow picker to create session modal | feature | @jeremyeder | Mar 12 | - ARIA accessibility violations - Type system issues - 12 days since last commit |
| 17 | #621 — fix: offer `dnf install kind` on Fedora when kind is missing | refactor | @github-actions | Mar 12 | - Doesn't implement feature request - Shows command vs automating |
| 18 | #755 — [Amber] Fix: feat(public-api): add /v1/sessions/:id/runs endpoint | feature | @github-actions | Mar 12 | - Critical SSE buffering bug - Fix available but not applied |
| 19 | #661 — Claude/daily sdk update action | feature | @jeremyeder | Mar 12 | - uv lock regenerates full lockfile - Missing set -o pipefail |
| 20 | #775 — ci(deps): bump actions/setup-node from 4 to 6 | chore | @dependabot | Mar 12 | - 1 CI failure |
| 21 | #777 — ci(deps): bump actions/upload-artifact from 4 to 7 | chore | @dependabot | Mar 12 | - 1 CI failure |
| 22 | #813 — build(deps): bump the npm_and_yarn group across 3 directories | chore | @dependabot | Mar 12 | - 1 CI failure |
| 23 | #806 — build(deps): bump authlib from 1.6.6 to 1.6.7 | chore | @dependabot | Mar 12 | - 1 CI failure |
| 24 | #649 — Add session environment variables reference | docs | @syntaxsdev | Mar 12 | - 1 blocker |
| 25 | #810 — docs: V2 architecture docs, ADR-0007 | docs | @markturansky | Mar 12 | - 1 blocker |
Recommend Closing (0)
No PRs recommended for closing at this time.
Drafts (10)
| PR | Type | Author | Updated |
|---|---|---|---|
| #607 — feat: workspace-rbac-quota-design | feature | @jeremyeder | Mar 12 |
| #597 — feat: add kind-local overlay and kind-local-up target | feature | @jeremyeder | Mar 12 |
| #698 — feat: add MCP server configuration management | feature | @jeremyeder | Mar 12 |
| #752 — docs(adr): ADR-0007 Application-Level Configuration Management | docs | @jeremyeder | Mar 12 |
| #846 — fix(workflow): resolve stale greeting and race condition | bug-fix | @jeremyeder | Mar 12 |
| #899 — feat(api-server): user-scoped queries for multi-tenant isolation | feature | @maskarb | Mar 12 |
| #850 — feat(frontend): complete UI reskin with semantic design tokens | feature | @jeremyeder | Mar 12 |
| #606 — feat: add session-config repo support (spec.configRepo) | feature | @jeremyeder | Mar 12 |
| #745 — feat(frontend): add Jeremy's Theme (Claude Code CLI style) | feature | @jeremyeder | Mar 12 |
| #756 — [Amber] Fix: security(runner): reject direct AG-UI connections | feature | @github-actions | Mar 12 |
Summary
| Bucket | Count |
|---|---|
| Ready for review | 6 |
| In queue (milestone) | 28 |
| Almost ready | 6 |
| Blocked | 35 |
| Drafts | 10 |
| Total open | 52 |
By Type
| Type | Count |
|---|---|
| feature | 18 |
| unknown | 11 |
| bug-fix | 9 |
| chore | 8 |
| docs | 5 |
| refactor | 1 |
List view
0 issues of 17 selected
- Status: Open (in progress).ambient-code/platformnumber 820#820 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 759#759 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 832#832 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 621#621 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 758#758 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 773#773 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 774#774 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 845#845 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 855#855 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 870#870 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 895#895 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 618#618 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 649#649 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 780#780 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 791#791 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 849#849 In ambient-code/platform;
- Status: Open (in progress).ambient-code/platformnumber 863#863 In ambient-code/platform;