fix(workflow): render startup greeting client-side with race condition fixes#849
Open
jeremyeder wants to merge 1 commit intoambient-code:mainfrom
Open
fix(workflow): render startup greeting client-side with race condition fixes#849jeremyeder wants to merge 1 commit intoambient-code:mainfrom
jeremyeder wants to merge 1 commit intoambient-code:mainfrom
Conversation
…ode#780 + ambient-code#846) Replaces the server-side workflow greeting round-trip with a client-side approach that provides instant feedback when users select a workflow. Backend: - Add `startupPrompt` and `greeting` fields to OOTBWorkflow struct - Parse both fields from ambient.json in workflow repos Frontend: - Display `greeting` text with typewriter streaming effect below tiles - Add `hidden` option to sendMessage for system-initiated messages - Remove 3-second hardcoded sleep after workflow activation - Remove server-side workflowGreeting state (no LLM round-trip needed) Runner: - Remove server-side greeting trigger logic (no longer needed) - Clean up unused imports (aiohttp, uuid, load_ambient_config) Tests: - Add vitest regression tests for stale greeting and race conditions - Add vitest.config.ts for frontend unit testing Companion: ambient-code/workflows#61 (ambient.json fixes) Supersedes ambient-code#780 and ambient-code#846. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jeremyeder
force-pushed
the
fix/workflow-startup-combined
branch
from
0f975c2 to
3a5266a
Compare
Contributor
Review Queue — Blockers Found
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combines PR #780 and PR #846 into a single PR:
startupPromptfield toOOTBWorkflowstruct and parse it fromambient.jsonin workflow reposuse-workflow-managementWhat was broken
When a user clicked a workflow tile (e.g. "PRD RFE Workflow"), the workflow activated successfully but:
startupPromptfromambient.jsonwas never served by the OOTB endpoint (missing field)Test plan
cd components/frontend && npx vitest run— verify regression tests passSupersedes #780 and #846.
🤖 Generated with Claude Code