Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughDockerfile.dev base image changed from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/backend/Dockerfile.dev`:
- Line 4: The Dockerfile.dev currently sets USER 0 (root) which is a security
regression; update Dockerfile.dev to create and switch to a non-root user
(create a dedicated group/user, set a non-root UID/GID), adjust ownership of
application directories/files with chown to that user, set an appropriate
WORKDIR/HOME for that user, and replace the final USER 0 line with the non-root
username or UID so the container does not run as root at runtime. Ensure any
files or ports requiring access are owned or permissioned for that user so the
build and runtime steps (e.g., install/build steps and the final process) run
correctly without root.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 8a0a4472-8499-4b68-8efd-f80a0ca1b2e9
📒 Files selected for processing (1)
components/backend/Dockerfile.dev
Replace golang:1.24-alpine with registry.access.redhat.com/ubi9/go-toolset:1.24. Remove apk install of git and build-base as go-toolset already includes them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Martin Prpič <mprpic@redhat.com>
e5eee4d to
4fe8d2d
Compare
Replace golang:1.24-alpine with
registry.access.redhat.com/ubi9/go-toolset:1.24. Remove apk install of git and build-base as go-toolset already includes them.