fix(frontend): migrate dev Dockerfile from Docker to UBI image#946
fix(frontend): migrate dev Dockerfile from Docker to UBI image#946mergify[bot] merged 2 commits intomainfrom
Conversation
Replace node:20-alpine with registry.access.redhat.com/ubi9/nodejs-20 for consistency with other components. Remove apk install of libc6-compat, python3, make, and g++ as the UBI nodejs-20 s2i builder image already includes them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Martin Prpič <mprpic@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughFrontend Docker development image updated: base changed to a Red Hat UBI9 Node.js image, Alpine-specific package steps removed, root user and working directory ensured, telemetry disabled, port 3000 exposed, and container CMD installs deps then starts the dev server. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@components/frontend/Dockerfile.dev`:
- Line 4: The Dockerfile contains a "USER 0" directive that forces the container
to run as root; either remove or replace it with the non-root user provided by
the UBI image (UID 1001) so the container runs as a non‑root user, or if running
as root is required for development, leave "USER 0" but add a clear comment next
to the "USER 0" line explaining the reason (e.g., volume permission workarounds)
and that it is only for dev; update any related build/run docs to reflect the
chosen approach and ensure tests still pass when using USER 1001 (check startup
scripts and file permissions).
- Line 2: The Dockerfile base image is unpinned; update the FROM line in
components/frontend/Dockerfile.dev (the FROM instruction referencing
registry.access.redhat.com/ubi9/nodejs-20) to a specific tag (for example change
to registry.access.redhat.com/ubi9/nodejs-20:1 or another chosen
timestamped/major tag) so builds are reproducible; ensure you commit the updated
FROM value and verify the image tag chosen matches the desired compatibility
level.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: a9d39c2e-6e1d-4cd6-8429-6fc7503524d5
📒 Files selected for processing (1)
components/frontend/Dockerfile.dev
Pin nodejs-20 image to :1 for reproducible builds. Add comment explaining why root is needed in the dev container. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Merge Queue Status
This pull request spent 15 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
Replace node:20-alpine with registry.access.redhat.com/ubi9/nodejs-20 for consistency with other components. Remove apk install of libc6-compat, python3, make, and g++ as the UBI nodejs-20 s2i builder image already includes them.