This repository has been archived by the owner on May 3, 2024. It is now read-only.
chore(scripts): remove postinstall and preinstall #1386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
postinstall
andpreinstall
scriptsAlso fixed an issue with the bundle-size workflow which was validating development asset size instead of production asset size. I had to add a new script for it since you can't define NODE_ENV separately for install and build scripts in this workflow.
Minor refactor in how NODE_ENV is set in workflows.
Motivation and Context
presinstall
runscheck-engines
which is not needed since we haveengine-strict=true
in.npmrc
. That enforces this without an additional dependency.postinstall
runsnpm run build
which is not super useful as we don't always need a build on every install, and often we need a production build, so we have to run it again sincenpm install
/npm ci
needs to be run withNODE_ENV
asdevelopment
.I added
npm run build
as a step in the unit/lint workflow to continue validating that build succeeds.How Has This Been Tested?
Worfklows running on this PR.
Types of Changes
Checklist:
What is the Impact to Developers Using One App?
N/A