Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(scripts): remove postinstall and preinstall #1386

Merged
merged 1 commit into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pr-labeler.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
feature: ['feature/*', 'feat/*']
fix: ['fix/*', 'bug/*']
fix: ['fix/*', 'bug/*', 'bugfix/*']
chore: chore/*
documentation: docs/*
refactor: refactor/*
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/bundle-size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:
env:
NODE_ENV: development
with:
build-script: "build:bundle"
build-script: "build:bundle:prod"
clean-script: "clean:build"
pattern: "./build/**/*.js"
strip-hash: \d+\.\d+\.\d+[-\S+]*\/
exclude: "{./build/**/i18n/*.js,./build/**/legacy/**,./build/**/tmp/**,**/*.map,**/node_modules/**}"
exclude: "{./build/**/i18n/*.js,./build/**/legacy/**,./build/**/tmp/**,**/node_modules/**}"
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,14 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: npm install
run: NODE_ENV=development npm ci
run: npm ci
env:
NODE_ENV: development
HUSKY: 0
- name: npm run build
run: npm run build
env:
NODE_ENV: production
- name: npm unit test
run: npm run test:unit
- name: npm lint test
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/on-pr_dangerJS.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,12 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: npm install
run: NODE_ENV=development npm ci
run: npm ci
env:
HUSKY: 0
NODE_ENV: development
HUSKY: 0
- name: Danger
run: NODE_ENV=production npm run test:danger
run: npm run test:danger
env:
NODE_ENV: production
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
3 changes: 2 additions & 1 deletion .github/workflows/on-pr_one-app-integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ jobs:
with:
node-version-file: .nvmrc
- name: npm install
run: NODE_ENV=development npm ci
run: npm ci
env:
NODE_ENV: development
HUSKY: 0
- name: Build docker image
run: docker build -t one-app:at-test . --build-arg USER=root --build-arg VERSION=$(cat .nvmrc)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,14 @@ jobs:
- name: One App release
id: vars
run: |
NODE_ENV=development npm ci
npm ci
git config --local user.email "[email protected]"
git config --local user.name "OneAmexBot"
npm run release
git add .
git commit -m "docs(changelog): update"
env:
NODE_ENV: development
HUSKY: 0
- name: Create release pull request
uses: peter-evans/create-pull-request@v6
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
"npm": ">=8"
},
"scripts": {
"preinstall": "npx check-engines@1",
"rimraf": "node -e \"process.argv.slice(1).forEach(path => require('node:fs').rmSync(path, { recursive: true, force: true }));\" --",
"clean": "npm run clean:build && npm run clean:test",
"clean:build": "npm run rimraf dist lib build lastBuild.json stats.json",
"clean:test": "npm run rimraf test-results",
"prebuild": "npm run clean:build",
"build:bundle:prod": "cross-env NODE_ENV=production npm run build:bundle",
"build:bundle": "cross-env \"NODE_OPTIONS=--max-old-space-size=4096 --openssl-legacy-provider\" bundle-one-app",
"build:server": "cross-env BABEL_ENV=server babel src --out-dir lib --ignore \"**/__mocks__\"",
"build:service-workers": "node scripts/build-service-workers.js",
Expand Down Expand Up @@ -42,7 +42,6 @@
"drop-module": "drop-module",
"set-middleware": "set-middleware",
"set-dev-endpoints": "node scripts/set-dev-endpoints.js",
"postinstall": "npm run build",
"release:standard-version": "standard-version -n",
"release:changelog": "echo \"$(head -3 CHANGELOG.md)\n\n$(node_modules/.bin/conventional-changelog -p angular)\n\n$(tail -n +4 CHANGELOG.md)\" > CHANGELOG.md",
"release": "npm run release:standard-version && npm run release:changelog",
Expand Down
Loading