Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jaxsim.api package away from PhysicsModel #112

Merged
merged 32 commits into from
Mar 19, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Mar 14, 2024

  • Remove the usage of PhysicsModel in favor of the combination of JaxSimModel and the new KinDynParameters.
  • Move RBDAs to jaxsim.rbda.
  • Add the standard gravity constant as additional input of the RBDAs using it.
  • Move terrains to jaxsim.terrain.
  • Move ODE{State|Input}, PhysicsModel{State|Input}, SoftContactsState to jaxsim.api.ode_data.
  • Move VelRepr to jaxsim.api.common.
  • Remove jaxsim.sixd pass-through in favor of plain jaxlie.
  • Update RBDAs in jaxsim.rbda to use JaxSimModel instead of PhysicsModel.
  • Update argument names of RBDAs.

The unused classes will be removed in another PR. In this one, the aim is to make everything work with the new KinDynParameters class introduced in #101.


📚 Documentation preview 📚: https://jaxsim--112.org.readthedocs.build//112/

@diegoferigo diegoferigo force-pushed the transition_to_functional branch 2 times, most recently from 3e7277a to 5e9f93b Compare March 18, 2024 17:42
@diegoferigo diegoferigo force-pushed the transition_to_functional branch 2 times, most recently from 6fd2197 to 0ed97b9 Compare March 18, 2024 22:06
@diegoferigo diegoferigo changed the title Start transitioning away from PhysicsModel Migrate jaxsim.api package away from PhysicsModel Mar 18, 2024
@diegoferigo diegoferigo marked this pull request as ready for review March 18, 2024 22:28
@diegoferigo
Copy link
Member Author

Waiting @flferretti to be back, I added @traversaro as reviewer. This PR is not merging into main, we can do a final round of review in #108.

Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@diegoferigo diegoferigo merged commit ca32a7e into functional Mar 19, 2024
21 checks passed
@diegoferigo diegoferigo deleted the transition_to_functional branch March 19, 2024 10:23
@diegoferigo
Copy link
Member Author

I just realized that the removal of PhysicsModel (JaxSimModel.physics_model) might have solved #103 also for models with joints @traversaro @flferretti.

@traversaro
Copy link
Contributor

I just realized that the removal of PhysicsModel (JaxSimModel.physics_model) might have solved #103 also for models with joints @traversaro @flferretti.

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants