-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix api.contact.in_contact
#119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look @flferretti. It is indeed wrongly returning always an array with links_in_contact
corresponding to the passed link_names
. Right now, you are selecting the first elements of links_in_contact
, that would not correspond to link_names
. Did I get it right?
And, would it be a problem to rebase this PR on top of #108 as soon as #117 will get merged? The functional APIs of main
will be updated soon, I'd prefer to directly fix the final ones.
The length of `links_in_contact` was always equal to number of links in the model
0778c78
to
6e5779d
Compare
Co-authored-by: Diego Ferigo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
The returned length of
links_in_contact
was always equal to the total number of links in the model, instead of being equal to the length of the inputlink_names
📚 Documentation preview 📚: https://jaxsim--119.org.readthedocs.build//119/