Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rod deprecated method in the visualizer #155

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented May 20, 2024

This PR updates a deprecated method from rod in ami-iit/rod#34 in the visualizer


📚 Documentation preview 📚: https://jaxsim--155.org.readthedocs.build//155/

@flferretti flferretti marked this pull request as ready for review May 20, 2024 14:51
@flferretti flferretti self-assigned this May 20, 2024
@diegoferigo
Copy link
Member

Some of these changes are already part of #148

@flferretti
Copy link
Collaborator Author

Some of these changes are already part of #148

Alright, I'll edit the last commit to be restricted to the visualizer

@flferretti flferretti changed the title Update rod deprecated methods Update rod deprecated method in the visualizer May 20, 2024
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the missing options, LGTM.

src/jaxsim/mujoco/loaders.py Outdated Show resolved Hide resolved
@flferretti flferretti merged commit e282307 into main May 20, 2024
29 checks passed
@flferretti flferretti deleted the fix/rod_deprecation branch May 20, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants