Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project's metadata #193

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Update project's metadata #193

merged 5 commits into from
Jul 5, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Jul 3, 2024

  • Move content from setup.cfg to pyproject.toml
  • Update the README file.

Note: I verified that the METADATA has not been altered.

@flferretti this PR should also fix the missing description in PyPI.


馃摎 Documentation preview 馃摎: https://jaxsim--193.org.readthedocs.build//193/

@diegoferigo diegoferigo self-assigned this Jul 3, 2024
@diegoferigo
Copy link
Member Author

@flferretti any reason why ruff started failing from this PR?

@flferretti
Copy link
Collaborator

flferretti commented Jul 3, 2024

@flferretti any reason why ruff started failing from this PR?

The check B905 has been restored in 73e62b4, which was part of #186. We can either fix those with one command using ruff check --fix or restore the ignore in pyproject.toml

@diegoferigo
Copy link
Member Author

@flferretti any reason why ruff started failing from this PR?

The check B905 has been restored in 73e62b4, which was part of #186. We can either fix those with one command using ruff check --fix or restore the ignore in pyproject.toml

Mmh ok, and just to have a better picture, why the CI in that PR didn't fail after restoring the checks?

@flferretti
Copy link
Collaborator

flferretti commented Jul 3, 2024

Mmh ok, and just to have a better picture, why the CI in that PR didn't fail after restoring the checks?

The ruff action should check all the files, including the one in the tests folder. I'm not sure why it did pass, but I can check

@diegoferigo
Copy link
Member Author

Mmh ok, and just to have a better picture, why the CI in that PR didn't fail after restoring the checks?

The ruff action should check all the files, including the one in the tests folder. I'm not sure why it did pass, but I can check

What's strange is that also #187 is now passing, and both that and this PR are based on the current main. Somehow, it seems that the changes of setup.cfg and pyproject.toml altered the ruff configuration even if its configuration has not been touched.

@flferretti
Copy link
Collaborator

Mmh ok, and just to have a better picture, why the CI in that PR didn't fail after restoring the checks?

The ruff action should check all the files, including the one in the tests folder. I'm not sure why it did pass, but I can check

What's strange is that also #187 is now passing, and both that and this PR are based on the current main. Somehow, it seems that the changes of setup.cfg and pyproject.toml altered the ruff configuration even if its configuration has not been touched.

I guess I found the reason. Probably before ruff could not infer on the target python version in the pyproject.toml, which defaults to py38, and the strict argument has been introduced in py310 with PEP 618. For this reason, the B905 check was just ignored

@diegoferigo
Copy link
Member Author

@flferretti thanks for the explanation, it makes sense. I just fixed by passing strict=True to all our zip calls.

Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Diego, LGTM! I added a couple comments

README.md Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@diegoferigo diegoferigo force-pushed the remove_setup.cfg branch 3 times, most recently from da3c4fe to c744787 Compare July 5, 2024 14:01
@diegoferigo diegoferigo merged commit 481a47a into main Jul 5, 2024
29 checks passed
@diegoferigo diegoferigo deleted the remove_setup.cfg branch July 5, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants