-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow keeping the base pose when a model is reduced #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried with my humanoid class for PPO and I've encountered a problem related to the new ABA version in the following line:
jaxsim/src/jaxsim/physics/algos/aba.py
Line 98 in 0eab286
vJ = S[i] * qd[ii] |
In fact respect to the one presented in #35 I've seen that you've removed a part of the code:
98c81
< vJ = S[i] * qd[i - 1] if qd.size != 0 else S[i] * 0
#35
---
> vJ = S[i] * qd[ii]
#42
This should allow to treat the case in which the model has no joints, e.g. in the case of this PR, when every joint is blocked
Thanks, I didn't test this case. Should be fixed now, let me know if you still have problems. |
Thanks for your changes Diego! I'm now encoutering a small issue that I described in #37. In particular, after having reduced the model, when I try to simulate using |
Mmh, I guess that by JIT-compiling a This is not something we want to achieve in the short term since it would involve using |
Thank you for your feedback! Looks good to me |
No description provided.