Add GPU Performance Notice #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, as of now there is pretty much not a lot added, let me know if we should (and which) benchmarks from this issue we might want to include, and what information we should give users with regards to different systems and JAX. |
flferretti
reviewed
Aug 4, 2025
README.md
Outdated
Comment on lines
336
to
337
| | Authors | Maintainers | | ||
| |:------:|:-----------:| |
README.md
Outdated
Comment on lines
88
to
90
| > [!NOTE] | ||
| > GPU performance with JaxSim may vary. If you intend to run the package on a laptop GPU, | ||
| > keep in mind that the performance of some programs may be significantly slower than running on a desktop class GPU. |
There was a problem hiding this comment.
This is not directly related to JaxSim, but rather to JAX itself, or in general to every library that runs on GPU. WDYT @ami-iit/darwin?
There was a problem hiding this comment.
Agree, I would remove this
CarlottaSartore
requested changes
Sep 4, 2025
README.md
Outdated
Comment on lines
88
to
90
| > [!NOTE] | ||
| > GPU performance with JaxSim may vary. If you intend to run the package on a laptop GPU, | ||
| > keep in mind that the performance of some programs may be significantly slower than running on a desktop class GPU. |
There was a problem hiding this comment.
Agree, I would remove this
CarlottaSartore
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Thanks @lucaslibshutz We will merge it with the changes highlighted in the review
Co-authored-by: Filippo Luca Ferretti <[email protected]>
flferretti
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a small change to
README.mdto alert users about performance differences between laptop and desktop GPUs. I also fixed a broken filepath inCONTRIBUTING.md, as theworkflowsfolder was linked under thegithuband not the.githubfolder. Let me know if we should add some example performance numbers so that users know what to expect when running certain classes of programs!📚 Documentation preview 📚: https://jaxsim--446.org.readthedocs.build//446/
P.S: Please ignore the minor table and other small format improvements, my
nvimconfiguration has aprettierplugin installed that needs to be disabled. My apologies!