Fix ReadTheDocs preview url in PRs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure that the empty string is effective. This PR still uses the old workflow. I guess we'll figure this out in the next PR after merging this one. |
|
Thanks @diegoferigo! You can also use |
flferretti
approved these changes
Feb 2, 2024
I know what it is but I never used it yet. Do you think that it's useful also in this case, where the trigger is opening a PR and the result is an update of the first message? For the time being, I'll be merging as it is. I'll fix the behavior in a new PR, if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves preview url problem described in #73 (comment).
📚 Documentation preview 📚: https://jaxsim--74.org.readthedocs.build/en/74/