Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pytest in CI only in PRs that update either sources or tests #80

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Feb 5, 2024

Since running pytest is pretty slow (~1h), let's mitigate our contribution on global warming by preventing to run the corresponding CI step when not needed.

I used https://github.com/dorny/paths-filter that seems quite popular.

Note that this change only targets PRs, not CI pipelines on branches. We just need green CI on PRs for merging.


📚 Documentation preview 📚: https://jaxsim--80.org.readthedocs.build//80/

@diegoferigo diegoferigo self-assigned this Feb 5, 2024
@diegoferigo diegoferigo marked this pull request as ready for review February 5, 2024 12:06
@diegoferigo
Copy link
Member Author

I'll squash merge this PR, ignore the dirty commit names.

Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@diegoferigo diegoferigo merged commit 217f743 into main Feb 5, 2024
21 checks passed
@diegoferigo diegoferigo deleted the diegoferigo-patch-1 branch February 5, 2024 16:39
flferretti added a commit to traversaro/jaxsim that referenced this pull request Feb 27, 2024
flferretti added a commit to traversaro/jaxsim that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants