-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lxml dependency #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @giotherobot, thanks for the contribution. Can you please add lxml
also to environment.yml
?
There are still some dependencies missing to run |
Yep, that's right. Those are system dependencies that are expected to be found in the system in the case @flferretti on the long term, we should consider to add them as |
|
I guess the tricky aspect is that sdformat is not on PyPI, and I am not sure if it will ever be there. Probably we can fallback to the |
@traversaro isn't it python-sdformat?
This looks good, so we are not forced to use gazebo |
Nope, that's a third-party project, not what @traversaro meant.
Yep this can be done. When I tried many months ago, what I didn't like of the plain python bindings of sdformat is that I could not manage to get a proper error in stdout if the input URDF or SDF is malformed. Calling |
If you have time, it would be useful to report this upstream in https://github.com/gazebosim/sdformat, Python bindings of sdformat and gz libraries in general to not have a lot of users at the moment, so feedback from actual users of the bindings is quite precious for sdformat upstream developers. |
📚 Documentation preview 📚: https://jaxsim--89.org.readthedocs.build//89/