Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact params estimation in fixed-base models #98

Merged
merged 3 commits into from
Mar 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/jaxsim/api/contact.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,13 @@ def estimate_model_height(model: Model.JaxSimModel) -> jtp.Float:
model=model, soft_contacts_params=soft_contacts.SoftContactsParams()
)

W_p_CoM = Model.com_position(model=model, data=zero_data)
W_pz_CoM = Model.com_position(model=model, data=zero_data)[2]

if model.physics_model.is_floating_base:
W_pz_C = collidable_point_positions(model=model, data=zero_data)[:, -1]
return 2 * (W_p_CoM[2] - W_pz_C.min())
return 2 * (W_pz_CoM - W_pz_C.min())

return 2 * W_p_CoM
return 2 * W_pz_CoM

max_δ = (
max_penetration
Expand Down
Loading