Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PeriphDrivers): Fix SDHC Peripheral Failure for Alternative System Clocks #1041

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

OzgunKanal
Copy link
Contributor

Description

According to the UG, SDHC peripheral is driven by always 96 MHz. Therefore, using System clock in the function MXC_SDHC_Get_Input_Clock_Freq results failure in SDHC peripheral when SytemClock is configured other than 96 MHz. Moreover, according to the UG the SDHC is driven by the 96 MHz Internal High-Speed Oscillator. Similar situations occur for ME10, ME13 and AI87 and commits relating to these MCUs will be pushed after this commit, discussions and related tests.

…efore, using System clock in the MXC_SDHC_Get_Input_Clock_Freq results failure in SDHC peripheral. Moreover, according to the UG the SDHC is driven by the 96 MHz Internal High-Speed Oscillator. Similar situations occur for ME10, ME13 and AI87 and commits will be done after this commit, discussions and related tests for other MCUs.
@github-actions github-actions bot added the MAX32665 Related to the MAX32665 (ME14) label Jun 11, 2024
@OzgunKanal OzgunKanal changed the title ME14 SDHC Peripheral Failure Fixing when System Clock is not 96 MHz fix:ME14 SDHC Peripheral Failure Fixing when System Clock is not 96 MHz Jun 11, 2024
@OzgunKanal OzgunKanal changed the title fix:ME14 SDHC Peripheral Failure Fixing when System Clock is not 96 MHz fix: ME14 SDHC Peripheral Failure Fixing when System Clock is not 96 MHz Jun 11, 2024
@OzgunKanal OzgunKanal changed the title fix: ME14 SDHC Peripheral Failure Fixing when System Clock is not 96 MHz fix(PeriphDrivers): ME14 SDHC Peripheral Failure Fixing when System Clock is not 96 MHz Jun 11, 2024
@Jake-Carter
Copy link
Contributor

Thanks @OzgunKanal, agreed we can use the oscillator frequency macros for this instead of SystemCoreClock. I think this change is good to apply to the other micros as well.

@github-actions github-actions bot added MAX32570 Related to the MAX32570 (ME13) MAX32650 Related to the MAX32650 (ME10) MAX78002 Related to the MAX78002 (AI87) labels Jun 30, 2024
… in another example and results build check failure.

Moreover, CRYPTO_FREQ_A3 is reverted back to number because CRYPTO_FREQ can be defined by the user that makes CRYPTO_FREQ_A3 undefined and results failure.
@OzgunKanal OzgunKanal requested a review from Jake-Carter June 30, 2024 15:56
@Jake-Carter Jake-Carter changed the title fix(PeriphDrivers): ME14 SDHC Peripheral Failure Fixing when System Clock is not 96 MHz fix(PeriphDrivers): Fix SDHC Peripheral Failure for Alternative System Clocks Jul 1, 2024
@Jake-Carter Jake-Carter merged commit b66d772 into analogdevicesinc:main Jul 1, 2024
11 checks passed
@OzgunKanal OzgunKanal deleted the me14_sdhc_get_inp_clk branch July 9, 2024 12:39
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MAX32570 Related to the MAX32570 (ME13) MAX32650 Related to the MAX32650 (ME10) MAX32665 Related to the MAX32665 (ME14) MAX78002 Related to the MAX78002 (AI87)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants