Skip to content

Better packaging - #527

Closed
xaltsc wants to merge 4 commits into
andrewrabert:mainfrom
xaltsc:flake-with-updated-cef
Closed

Better packaging#527
xaltsc wants to merge 4 commits into
andrewrabert:mainfrom
xaltsc:flake-with-updated-cef

Conversation

@xaltsc

@xaltsc xaltsc commented Jun 22, 2026

Copy link
Copy Markdown

Closes #525

Blocked by #515

@xaltsc
xaltsc force-pushed the flake-with-updated-cef branch from 2f4d655 to be0a01d Compare June 22, 2026 10:53
@xaltsc

xaltsc commented Jun 22, 2026

Copy link
Copy Markdown
Author

One issue with this PR is that the CEF versions have to be manually kept in sync between the one defined here and the one used by the rust crate.

See #526 for the issue regarding automation of this task.

@xaltsc
xaltsc force-pushed the flake-with-updated-cef branch 2 times, most recently from 982b34e to 00f6602 Compare June 22, 2026 12:09
@xaltsc
xaltsc marked this pull request as draft June 23, 2026 01:08
@andrewrabert andrewrabert added nix Nix & NixOS enhancement New feature or request labels Jun 25, 2026
@andrewrabert andrewrabert changed the title Flake: allow updating CEF Allow updating CEF Jun 25, 2026
@xaltsc xaltsc changed the title Allow updating CEF Better packaging Jun 25, 2026
@xaltsc

xaltsc commented Jun 25, 2026

Copy link
Copy Markdown
Author

DO NOT merge this one yet, I was working on something else, and it turns out that better packaging is needed. I'll likely work on #545 as well in a third commit of this PR.

@xaltsc

xaltsc commented Jun 26, 2026

Copy link
Copy Markdown
Author

As I'm trying to build dependencies using crane, I'm hitting the same issue as in jellyfin/jellyfin-desktop#543 (comment)

error: failed to run custom build command for `cef-dll-sys v149.1.0+149.0.4`

Caused by:
  process didn't exit successfully: `/build/source/src/target/release/build/cef-dll-sys-6ead5d647d44dfb1/build-script-build` (exit status: 1)
  --- stdout
  cargo::rerun-if-changed=build.rs
  cargo::rerun-if-env-changed=FLATPAK
  cargo::rerun-if-env-changed=CEF_PATH
  Using CEF path from environment: /nix/store/ql68ks7bgvz88daaj13w977crv8d1z2m-cef-lib-149.0.4
  CEF_PATH is invalid (File I/O error: failed to open file `/nix/store/ql68ks7bgvz88daaj13w977crv8d1z2m-cef-lib-149.0.4/archive.json`: No such file or direc>

  --- stderr
  Error: HTTP request error: io: failed to lookup address information: Temporary failure in name resolution

  Caused by:
      io: failed to lookup address information: Temporary failure in name resolution
warning: build failed, waiting for other jobs to finish...

The error is in cef-download which I assume expects the cef tarball.

@xaltsc

xaltsc commented Jun 26, 2026

Copy link
Copy Markdown
Author

Opened an issue tauri-apps/cef-rs#426

@xaltsc
xaltsc force-pushed the flake-with-updated-cef branch 5 times, most recently from a421d94 to 1b80f9e Compare June 26, 2026 18:17
@xaltsc xaltsc mentioned this pull request Jun 26, 2026
@xaltsc

xaltsc commented Jun 26, 2026

Copy link
Copy Markdown
Author

I've moved the crane stuff to another PR #554, this out of scope for this one.

Once the previous PR is merged, this one should be ready for merging.

@xaltsc

xaltsc commented Jun 26, 2026

Copy link
Copy Markdown
Author

There's one annoying thing: I have rebased during this PR, and this has changed the hash of the commit from #515 . Merging automatically fails and gives two identical commits (but this can be easily solved).

Please ask me to correct history before merging subsequent PRs.

@xaltsc

xaltsc commented Jul 6, 2026

Copy link
Copy Markdown
Author

Last commit closes #540

Tested as much as I could without switching to Gnome (I guess it works).

@xaltsc
xaltsc force-pushed the flake-with-updated-cef branch from 2458403 to 17c0285 Compare July 7, 2026 08:20
@xaltsc
xaltsc force-pushed the flake-with-updated-cef branch from 17c0285 to bfd987f Compare July 7, 2026 11:30
@andrewrabert

Copy link
Copy Markdown
Owner

@xaltsc please combine the nix PR's and I'll marge asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request nix Nix & NixOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flake: update CEF ourselves

2 participants