Skip to content

Add devshells - #543

Closed
xaltsc wants to merge 6 commits into
andrewrabert:mainfrom
xaltsc:flake-devshells
Closed

Add devshells#543
xaltsc wants to merge 6 commits into
andrewrabert:mainfrom
xaltsc:flake-devshells

Conversation

@xaltsc

@xaltsc xaltsc commented Jun 24, 2026

Copy link
Copy Markdown

This is an attempt at solving #539.

The current commit is an extremely crude approximation of what is needed. PLEASE DO NOT MERGE.

There's a competing effort in PR #538.

Blocked by #528

@xaltsc
xaltsc force-pushed the flake-devshells branch 3 times, most recently from 6e9f64c to 04b34a8 Compare June 24, 2026 20:13
@xaltsc

xaltsc commented Jun 24, 2026

Copy link
Copy Markdown
Author

So, I'm trying to use nixpkgs''s mpv` libs as requested by @andrewrabert.

$JFN_MPV_INCLUDE_DIR has been set to various values, however, it's still impossible to find client.h.

I'm getting the following error when running just clippy:

  --- stderr
  Error: "could not locate mpv/client.h in any of: [\"third_party/mpv/include\"]\nSet JFN_MPV_INCLUDE_DIR, EXTERNAL_MPV_DIR, or install libmpv via pkg-config."

So it doesn't look like JFN_MPV_INCLUDE_DIR is considered at all.

@xaltsc

xaltsc commented Jun 24, 2026

Copy link
Copy Markdown
Author

Also, when running just clippy with CEF_PATH set (to the wrong one, but that's not the issue), I get

  CEF_PATH is invalid (File I/O error: failed to open file `/nix/store/v4lvgffqpc359ya581qw0p6fcralbpfk-cef-binary-149.0.4/archive.json`: No such file or directory (os error 2)),

No such archive.json exist. I assume it's something that exist in the downloaded tarball which is the scenario that clippy expects. But build works without it.

@xaltsc

xaltsc commented Jun 24, 2026

Copy link
Copy Markdown
Author

Also, just build fetches mpv and CEF, which is unnecessary, and even tries to build them (afaict, libplacebo is not a dependency of jfnd itself).

@xaltsc

xaltsc commented Jun 24, 2026

Copy link
Copy Markdown
Author

I don't think I can work on this PR further without taking a maximalist approach (which I refuse to).

Build methods needs to be patched before I can advance.

@xaltsc
xaltsc force-pushed the flake-devshells branch from 04b34a8 to ab320db Compare June 24, 2026 22:03
@andrewrabert andrewrabert added nix Nix & NixOS enhancement New feature or request labels Jun 25, 2026
@andrewrabert andrewrabert changed the title [WIP] Flake: add devshells [WIP] Add devshells Jun 25, 2026
@andrewrabert andrewrabert changed the title [WIP] Add devshells Add devshells Jun 25, 2026
@xaltsc xaltsc mentioned this pull request Jun 26, 2026
@xaltsc xaltsc mentioned this pull request Jul 4, 2026
@andrewrabert

Copy link
Copy Markdown
Owner

@xaltsc please combine the nix PR's and I'll marge asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request nix Nix & NixOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants