[thekhegay]

PR Checklist

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

refactor-jasmine-vitest drops default access type of spyOnProperty
Jasmine uses 'get' when third argument is missing, vi.spyOn without it is typed and run as method spy

This spec passes on Jasmine:

class Session {
  get user(): string {
    return 'real';
  }
}

it('stubs the getter', () => {
  const session = new Session();
  spyOnProperty(session, 'user').and.returnValue('mocked');
  expect(session.user).toBe('mocked');
});

ng g @schematics/angular:refactor-jasmine-vitest on 22.3.0-next.3 turns it into vi.spyOn(session, 'user').mockReturnValue('mocked') and ng test fails to build:

✘ [ERROR] TS2769: No overload matches this call.

Without type check Vitest throws vi.spyOn() can only spy on a function at runtime

What is the new behavior?

transformPrimarySpy adds 'get' when spyOnProperty has two arguments, explict access type is kept as is
Same spec converts to vi.spyOn(session, 'user', 'get').mockReturnValue('mocked') and passes under ng test

Existing case in jasmine-spy_spec.ts expected vi.spyOn(service, 'myProp').mockReturnValue(undefined) for bare spyOnProperty, so it pinned this output
Updated it and added two cases, chained one and explicit 'set', updated and chained ones fail on main

Does this PR introduce a breaking change?

• Yes
• No

Other information

Bare spyOnProperty(obj, 'prop') still gets .mockReturnValue(undefined) from #33266, so after this change it compiles only when getter type allows undefined, same as bare spyOn on method that returns string

[gemini-code-assist]

Code Review

This pull request updates the Jasmine-to-Vitest schematic transformer to correctly handle spyOnProperty calls. When spyOnProperty is invoked with only two arguments, the transformer now appends 'get' as the third argument to vi.spyOn to match Jasmine's default behavior. Additionally, unit tests have been updated and added to verify this default behavior, chained calls, and explicit access types. There are no review comments, and we have no feedback to provide.

[alan-agius4]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 4ea7c67
• 22.2.x: 7f3840c