Skip to content

fix(@schematics/angular): keep the default getter access type of spyOnProperty in refactor-jasmine-vitest #34543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Oct 28, 2026
Merged

fix(@schematics/angular): keep the default getter access type of spyOnProperty in refactor-jasmine-vitest #34543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-spy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,18 @@ function transformPrimarySpy(node: ts.CallExpression, refactorCtx: RefactorConte
) {
addVitestValueImport(pendingVitestValueImports, 'vi');

// `spyOnProperty` defaults to the getter while `vi.spyOn` needs the access type to spy on
// a property instead of a method.
const args =
node.expression.text === 'spyOnProperty' && node.arguments.length === 2
? [...node.arguments, ts.factory.createStringLiteral('get', true)]
: node.arguments;

const viSpyOnCall = ts.factory.updateCallExpression(
node,
createPropertyAccess('vi', 'spyOn'),
node.typeArguments,
node.arguments,
args,
);

if (isChainedWithAnd(node)) {
Expand Down
14 changes: 12 additions & 2 deletions packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-spy_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,19 @@ describe('Jasmine to Vitest Transformer - transformSpies', () => {
},
{
description:
'should transform spyOnProperty(object, "prop") to vi.spyOn(object, "prop").mockReturnValue(undefined)',
'should transform spyOnProperty(object, "prop") to vi.spyOn(object, "prop", "get").mockReturnValue(undefined)',
input: `spyOnProperty(service, 'myProp');`,
expected: `vi.spyOn(service, 'myProp').mockReturnValue(undefined);`,
expected: `vi.spyOn(service, 'myProp', 'get').mockReturnValue(undefined);`,
},
{
description: 'should default the access type of a chained spyOnProperty to "get"',
input: `spyOnProperty(service, 'myProp').and.returnValue(42);`,
expected: `vi.spyOn(service, 'myProp', 'get').mockReturnValue(42);`,
},
{
description: 'should keep an explicit spyOnProperty access type',
input: `spyOnProperty(service, 'myProp', 'set');`,
expected: `vi.spyOn(service, 'myProp', 'set').mockReturnValue(undefined);`,
},
{
description: 'should transform .and.stub() to .mockImplementation(() => {})',
Expand Down
Loading