-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert BitRate and Information to double #1353
Convert BitRate and Information to double #1353
Conversation
I say let's convert everything to Next steps:
Rant, optional to readOur current design simply feels half-baked and there is way too much complexity just to support The only quantity that has some value from I'm sure we can find some reasonable solution to achieve the same thing, without going full Anyway, we can solve this after converting to Brain dump of how to approach multiple numeric typesThis is how I remember the different ways to approach multiple numeric types. We've had many a discussion on the topic.
Some relevant sources#714 |
#1195 is now merged |
…tion-double # Conflicts: # UnitsNet.Tests/CustomCode/IQuantityTests.cs # UnitsNet.Tests/IValueQuantityTests.cs # UnitsNet/GeneratedCode/Quantities/BitRate.g.cs # UnitsNet/GeneratedCode/Quantities/Information.g.cs
CanDeserializeLegacyDecimalQuantityJson CanDeserializeDoubleQuantityJson
# Conflicts: # UnitsNet.Serialization.JsonNet.Tests/AbbreviatedUnitsConverterTests.cs
In PR #1195 @angularsen asks @tmilnthorp:
How about we continue that discussion here? 😄
This PR is pretty straightforward and mimics #1195, except that
Information
is used as the typical decimal quantity in some tests. Because there won't be any decimal quantities left if these PRs get merged, I removed those tests in anticipation of completely removing all decimal support.