Fix progress dialog outside touch

[Alok-Silswal]

Purpose / Description

During a forced one-way / full sync, the progress dialog can currently be dismissed by tapping on the dimmed background (i.e. Outside the box).

Fixes

• Fixes Tapping outside of the progress box during a forced, one-way sync cancels the transfer #20073

Approach

• Added Cancel button to manually abort the full sync.
• Canellation logic now handles disabling of outside touch.

How Has This Been Tested?

Tested on my phone (Android 14, Xiaomi / HyperOS) using a debug build.

Outside touch no longer cancels syncing.

Videos attached as evidence.

Checklist

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings) (N/A – no visual UI changes)
• UI Changes: You have tested your change using the [Google Accessibility Scanner] (N/A – no UI changes)(https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor)

---

Before this change:

Outside_Touch_BEFORE.mp4

After this change:

Outside_Touch_AFTER.mp4

[welcome]

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

[david-allison]

The backend offers cancellation, but as far as I understand it, this PR removes the only way to access it (maybe the back button?)

You haven't shown evidence of testing for this change.

---

The other syncing dialogs have a 'cancel' button [sorry for the bad screensnip], is there a reason you didn't add this in?

[Alok-Silswal]

This change only disables cancellation via outside-touch. It does not change setCancelable(onCancel != null), so cancellation via the Back button remains available and continues to trigger cancelSync() as before.

The backend cancellation path is unchanged and no code regarding this has been touched; only accidental dismissal via background taps is prevented.

setCanceledOnTouchOutside(false) specifically controls outside-touch behavior without affecting other cancellation mechanisms.

Reference: https://developer.android.com/reference/android/app/Dialog#setCanceledOnTouchOutside(boolean)

---

The other syncing dialogs have a 'cancel' button [sorry for the bad screensnip], is there a reason you didn't add this in?

I intentionally avoided adding new UI here to keep the change minimal.

Other sync dialogs do include a Cancel button, but the forced full-sync dialog currently relies on the Back button for cancellation, and this PR preserves that existing behavior rather than introducing a new interaction.

---

If adding an explicit Cancel button here would be preferable for consistency, I will do the needful accordingly.

[Alok-Silswal]

You haven't shown evidence of testing for this change.

I have updated the PR to include the evidence of testing (i.e., screen recording).

---

The backend offers cancellation, but as far as I understand it, this PR removes the only way to access it (maybe the back button?)

Backend cancellation can still be done via the back button, as shown in the video below:

Cancellation.via.back.working.evidence.mp4

[david-allison]

The dialog must have an explicit cancel button if you're going to remove the 'cancel on touch outside' functionality

There's a lot of code changes here, and a lot of parameters, an additional refactor to define 'options' for withProgress may be useful

[Alok-Silswal]

There's a lot of code changes here, and a lot of parameters

Yes, code changes are there. But as far as the parameter is concerned, I have added only one parameter per function to disable outside touch.

For the changes, these are small recurring additions only. Nothing significant has been changed.

[Alok-Silswal]

an additional refactor to define 'options' for withProgress may be useful

Yes, it may be useful if

• there are several parameters as options, or
• for future reference to know that this is a default value

But for only one parameter, I will prefer to keep it as a direct argument to keep the modification minimal

@david-allison How shall I go about it?

[Alok-Silswal]

The dialog must have an explicit cancel button if you're going to remove the 'cancel on touch outside' functionality

Done!

Added.CANCEL.button.while.full.sync.mp4

[david-allison]

This seems overly complicated

There are only 3 usages of manualCancelButton, all sync related:

2 of which set cancelOnTouchOutside = false

---

For consistency:

• remove the cancelOnTouchOutside parameter
• keep the two new 'cancel' buttons
• inside withProgressDialog

                if (manualCancelButton != null) {
                    setCancelable(false)
+                   setCanceledOnTouchOutside(false)

[david-allison]

LGTM, cheers

[david-allison]

optional: This will be easier to merge if you

• squash merge
• provide a succinct commit title and description

[Alok-Silswal]

Yes! I am doing that only...

[Alok-Silswal]

I earlier (maybe a month ago), by mistake ran git pull origin main on this branch due to which un-related commits messed up my branch.

While trying to do squash and merge, I by mistake did something that closed this PR and now I am not able to re-open it.

optional: This will be easier to merge if you

• squash merge
• provide a succinct commit title and description

Either way, with those commits this would have not been possible.

[Alok-Silswal]

@david-allison I have created #20420 PR that do the same cleanly with the aforementioned feedback and same logic.