Skip to content

fix(sync-dialogue): prevent cancellation via outside touch#20420

Merged
criticalAY merged 1 commit intoankidroid:mainfrom
Alok-Silswal:fix-progress-outside-touch-dialogue-new
Mar 10, 2026
Merged

fix(sync-dialogue): prevent cancellation via outside touch#20420
criticalAY merged 1 commit intoankidroid:mainfrom
Alok-Silswal:fix-progress-outside-touch-dialogue-new

Conversation

@Alok-Silswal
Copy link
Contributor

Purpose / Description

During a forced one-way / full sync, the progress dialog can currently be dismissed by tapping on the dimmed background (i.e. Outside the box).

Fixes

Approach

  • Added Cancel button to manually abort the full sync.
  • Canellation logic now handles disabling of outside touch.

How Has This Been Tested?

Tested on my phone (Android 14, Xiaomi / HyperOS) using a debug build.

Outside touch no longer cancels syncing.

Videos attached as evidence.

Checklist

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings) (N/A – no visual UI changes)
  • UI Changes: You have tested your change using the [Google Accessibility Scanner] (N/A – no UI changes)(https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor)

Before this change:

Outside_Touch_BEFORE.mp4

After this change:

Outside_Touch_AFTER.mp4

@Alok-Silswal
Copy link
Contributor Author

Continued from #20210 PR.

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow on from #20210

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Mar 8, 2026
Copy link
Contributor

@criticalAY criticalAY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou!

@criticalAY criticalAY added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Mar 10, 2026
@criticalAY criticalAY added this pull request to the merge queue Mar 10, 2026
Merged via the queue into ankidroid:main with commit 8316935 Mar 10, 2026
19 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Mar 10, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tapping outside of the progress box during a forced, one-way sync cancels the transfer

3 participants