fix(sync-dialogue): prevent cancellation via outside touch#20420
Merged
criticalAY merged 1 commit intoankidroid:mainfrom Mar 10, 2026
Merged
Conversation
Contributor
Author
|
Continued from #20210 PR. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
During a forced one-way / full sync, the progress dialog can currently be dismissed by tapping on the dimmed background (i.e. Outside the box).
Fixes
Approach
Cancelbutton to manually abort the full sync.How Has This Been Tested?
Tested on my phone (Android 14, Xiaomi / HyperOS) using a debug build.
Outside touch no longer cancels syncing.
Videos attached as evidence.
Checklist
Before this change:
Outside_Touch_BEFORE.mp4
After this change:
Outside_Touch_AFTER.mp4