Skip to content

feat(whiteboard): two-finger scroll#20267

Merged
criticalAY merged 1 commit intoankidroid:mainfrom
BrayanDSO:feat/whiteboard-two-finger
Feb 5, 2026
Merged

feat(whiteboard): two-finger scroll#20267
criticalAY merged 1 commit intoankidroid:mainfrom
BrayanDSO:feat/whiteboard-two-finger

Conversation

@BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented Jan 30, 2026

Purpose / Description

Feature present in the old whiteboard that people missed

Approach

I didn't want to think too much, so I followed the approach used by the old whiteboard

private fun reinitializeSecondFinger(event: MotionEvent) {

After that, I added support for interacting with the screen with just one finger if stylus mode is enabled

How Has This Been Tested?

Galaxy Tab S9, Android 16

Screen_Recording_20260130_152118_AnkiDroid.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@BrayanDSO BrayanDSO changed the title Feat/whiteboard two finger feat(whiteboard): two-finger scroll Jan 30, 2026
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy, one borderline non-nit. Thanks!!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Jan 30, 2026
@BrayanDSO BrayanDSO force-pushed the feat/whiteboard-two-finger branch 2 times, most recently from d4c2f07 to 2a3ec55 Compare January 30, 2026 20:31
@BrayanDSO BrayanDSO added the Needs Author Reply Waiting for a reply from the original author label Jan 31, 2026
@BrayanDSO BrayanDSO force-pushed the feat/whiteboard-two-finger branch from 2a3ec55 to bfebd4c Compare January 31, 2026 20:49
@BrayanDSO BrayanDSO removed the Needs Author Reply Waiting for a reply from the original author label Jan 31, 2026
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but still good to go

@BrayanDSO BrayanDSO force-pushed the feat/whiteboard-two-finger branch 3 times, most recently from 1dbe915 to 677e377 Compare January 31, 2026 23:35
@BrayanDSO BrayanDSO force-pushed the feat/whiteboard-two-finger branch from 677e377 to d3101dc Compare February 5, 2026 19:25
also made possible to scroll with one finger if stylus mode is enabled
@BrayanDSO BrayanDSO force-pushed the feat/whiteboard-two-finger branch from d3101dc to 931a84a Compare February 5, 2026 19:57
@BrayanDSO BrayanDSO requested a review from criticalAY February 5, 2026 20:33
Copy link
Contributor

@criticalAY criticalAY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@criticalAY criticalAY added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 5, 2026
@criticalAY criticalAY added this pull request to the merge queue Feb 5, 2026
Merged via the queue into ankidroid:main with commit 264b232 Feb 5, 2026
15 checks passed
@github-actions github-actions bot added this to the 2.24 release milestone Feb 5, 2026
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants