feat(whiteboard): support gestures/keybinds#20268
Open
BrayanDSO wants to merge 5 commits intoankidroid:mainfrom
Open
feat(whiteboard): support gestures/keybinds#20268BrayanDSO wants to merge 5 commits intoankidroid:mainfrom
BrayanDSO wants to merge 5 commits intoankidroid:mainfrom
Conversation
Contributor
|
Important Maintainers: This PR contains Strings changes
|
BrayanDSO
force-pushed
the
feat/whiteboard-multi-finger
branch
from
6fb0f6f to
cb2d474
Compare
5 tasks
BrayanDSO
force-pushed
the
feat/whiteboard-multi-finger
branch
from
cb2d474 to
e8014a6
Compare
criticalAY
added
the
Blocked by dependency
BrayanDSO
force-pushed
the
feat/whiteboard-multi-finger
branch
from
9e468e3 to
f0239f8
Compare
BrayanDSO
removed
Blocked by dependency
BrayanDSO
force-pushed
the
feat/whiteboard-multi-finger
branch
from
f0239f8 to
032c8f2
Compare
BrayanDSO
force-pushed
the
feat/whiteboard-multi-finger
branch
from
032c8f2 to
7a96ffa
Compare
david-allison
requested changes
Mar 4, 2026
| REDO, | ||
| ; | ||
|
|
||
| override val preferenceKey: String get() = "binding_whiteboard_$name" |
Member
There was a problem hiding this comment.
name is subject to accidental refactor and we need to guard against this.
|
|
||
| val dx = abs(startX - currentX) | ||
| val dy = abs(startY - currentY) | ||
| if (dx >= touchSlop || dy >= touchSlop) { |
Member
There was a problem hiding this comment.
Could you make a comment on the math here, this doesn't need to be 'fixed', but a future implementor should be aware:
I suspect this doesn't matter as the refresh rate on most devices will be massive, so the position deltas will be small
If a large MotionEvent occurs, this code will pick the midway point from the start and the end. If the extremity is used, it may be outside the tap tolerance.
Member
Author
There was a problem hiding this comment.
should be more correct now
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/whiteboard/MultiTouchDetector.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/preferences/ReviewerControlPreference.kt
Outdated
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/ui/windows/reviewer/ReviewerFragment.kt
Show resolved
Hide resolved
david-allison
added
Needs Author Reply
the actions are restricted to 'both' sides of the card to simplify my life coding it. Also, that makes the UX simpler the only gestures available are the multi-finger taps and shake. Swipes and single taps can't be used because they conflict with the screen functionality
this way, the user can have gestures do different depending whether the whiteboard is enabled
BrayanDSO
force-pushed
the
feat/whiteboard-multi-finger
branch
from
7a96ffa to
35c09cc
Compare
BrayanDSO
removed
the
Needs Author Reply
Member
|
@BrayanDSO merge at your discretion. I'd mildly prefer a second look on this one, but don't want it to be blocking |
david-allison
approved these changes
Mar 12, 2026
Member
Author
|
I'd like this in 2.24. If someone doesn't merge it before that, I (or someone else) should do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Approach
Question and Answergestures are acceptedHow Has This Been Tested?
Galaxy Tab S9, Android 16
Screen_Recording_20260130_162646_AnkiDroid.mp4
Learning (optional, can help others)
Working on architecture is paying off. This was way easier than I expected by extending stuff instead of reorganizing everything.
Checklist
Please, go through these checks before submitting the PR.