Fix: flag menu icons sometimes appear without colors#20469
Fix: flag menu icons sometimes appear without colors#20469AayushKrGupta wants to merge 6 commits intoankidroid:mainfrom
Conversation
|
we need reproduction steps for this |
Hi @david-allison, sorry for the missing detail. Here are the steps to reproduce the intermittent grey icon issue: Steps: Open the reviewer, access the flag menu, study several cards (or switch between cards), and re-open the menu repeatedly. Observed Behavior: Eventually, the flag icons (Red, Orange, etc.) lose their specific colors and appear entirely grey. I've tested this on both the Legacy and New Study screens. Could you please reopen this so you can review the fix? |
Fixes #20464
Issue:
Flag icons in the reviewer menu sometimes appear grey instead of their assigned color.
Closing and reopening the menu restores the colors.
Cause:
Drawable instances were reused without ensuring tint was applied during each UI binding.
Solution:
• Ensure drawable mutation before applying tint
• Explicitly apply tint when binding flag menu items
• Refresh reviewer menu state to prevent cached icon states
• Ensure consistent behavior across reviewer, browser, and previewer screens
Testing:
All flag icons now consistently render with their correct colors.