Improve the "Rename note type" dialog#20471
Closed
dagangtj wants to merge 1 commit intoankidroid:mainfrom
Closed
Conversation
- Add "Name" hint to the text input field - Show red error text when note type already exists - Error message: "Note type already exists" - Clear error when input becomes valid Fixes ankidroid#20467
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
Contributor
|
Important Maintainers: This PR contains Strings changes
|
Member
|
Hi @dagangtj, are you aware of: https://github.com/ankidroid/Anki-Android/blob/main/AI_POLICY.md |
Member
Most likely not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20467
Changes
Implementation Details
android:hint="@string/name"toTextInputLayoutnameandnote_type_already_existsTextInputLayoutTesting