Skip to content

Improve the "Rename note type" dialog #20471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagangtj wants to merge 1 commit into from
+12 −1
Closed

Improve the "Rename note type" dialog #20471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions AnkiDroid/src/main/java/com/ichi2/anki/notetype/ManageNotetypes.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,16 @@ class ManageNotetypes : AnkiActivity(R.layout.activity_manage_note_types) {
waitForPositiveButton = false,
displayKeyboard = true,
callback = { dialog, text ->
val textInputLayout = dialog.findViewById<com.google.android.material.textfield.TextInputLayout>(R.id.dialog_text_input_layout)
val isNotADuplicate =
!allNotetypes.map { it.name }.contains(text.toString())

if (!isNotADuplicate && text.isNotEmpty()) {
textInputLayout?.error = getString(R.string.note_type_already_exists)
} else {
textInputLayout?.error = null
}

dialog.positiveButton.isEnabled = text.isNotEmpty() && isNotADuplicate
},
)
Expand Down
3 changes: 2 additions & 1 deletion AnkiDroid/src/main/res/layout/dialog_generic_text_input.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
android:paddingEnd="32dp"
android:paddingBottom="4dp"
app:errorEnabled="true"
android:paddingTop="16dp">
android:paddingTop="16dp"
android:hint="@string/name">

<com.google.android.material.textfield.TextInputEditText
android:id="@+id/dialog_text_input"
Expand Down
2 changes: 2 additions & 0 deletions AnkiDroid/src/main/res/values/03-dialogs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@

<string name="dialog_cancel">Cancel</string>
<string name="dialog_ok">OK</string>
<string name="name">Name</string>
<string name="note_type_already_exists">Note type already exists</string>
<string name="dialog_confirm" tools:ignore="UnusedResources">Confirm</string>
<string name="dialog_no">No</string>
<string name="dialog_yes">Yes</string>
Expand Down
Loading