Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing hashed passwords in database instead of plain text #35

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HimanshuC22
Copy link

[Fixes]

  • 'email' variable replaced with 'mail', causing error in API
  • generated uuid, which was required for registering user

Storing hashed passwords in database instead of plain text
[Fixes]
- 'email' variable replaced with 'mail', causing error in API
- generated uuid, which was required for registering user
@ankitrout2903
Copy link
Owner

Bro your code looks amazing but can you remove node modules from it😑😑
It is not a good practice to include node modules in a PR 😑😑

@HimanshuC22
Copy link
Author

Ok I will try to put that in gitignore.

[this will ensure that no node_modules are added in a commit]
@HimanshuC22
Copy link
Author

Added Node Modules in git ignore

@ankitrout2903
Copy link
Owner

Didn't recieved pr

@HimanshuC22
Copy link
Author

HimanshuC22 commented Oct 7, 2023 via email

@HimanshuC22
Copy link
Author

@ankitrout2903 any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants