Fix StdlibRandomNextBytes call #3150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszcz
previously approved these changes
Nov 6, 2024
janmasrovira
approved these changes
Nov 6, 2024
The hoon code that generates the stdlib call is: ``` => rm != |= [rng=* width=@] (raws:`_og`rng width) ``` i.e the random number generator is the first argument and the width is the second argument. We have the arguments transposed in the corresponding Juvix builtin API so the call was failing. This PR transposes the argumetns in the stdlib call so the builtin API and hoon generated nock code are compatible.
janmasrovira
force-pushed
the
fix-stdlib-random-next-bytes-call
branch
from
facbc72
to
0055c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hoon code that generates the stdlib call is:
juvix/src/Juvix/Compiler/Nockma/AnomaLib.hs
Line 101 in 1a8b632
i.e the random number generator is the first argument and the width is the second argument. We have the arguments transposed in the corresponding Juvix builtin API so the call was failing.
This PR transposes the argumetns in the stdlib call so the builtin API and hoon generated nock code are compatible.