Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StdlibRandomNextBytes call #3150

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Fix StdlibRandomNextBytes call #3150

merged 2 commits into from
Nov 7, 2024

Commits on Nov 6, 2024

  1. Fix StdlibRandomNextBytes call 

    The hoon code that generates the stdlib call is:

```
=>  rm  !=  |=  [rng=* width=@]   (raws:`_og`rng width)
```

i.e the random number generator is the first argument and the width is
the second argument. We have the arguments transposed in the
corresponding Juvix builtin API so the call was failing.

This PR transposes the argumetns in the stdlib call so the builtin API
and hoon generated nock code are compatible.
    @paulcadman @janmasrovira
    paulcadman authored and janmasrovira committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5bb2e3f View commit details
    Browse the repository at this point in the history

  2. Fix calls to StdlibRandomNextBytes in nockma eval tests

    @paulcadman @janmasrovira
    paulcadman authored and janmasrovira committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0055c6a View commit details
    Browse the repository at this point in the history