onepassword_info: replace subprocess.Popen() with run_command() #11193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ansibullbot
added
module
felixfontein
added
check-before-release
felixfontein
removed
the
backport-11
Co-authored-by: Felix Fontein <[email protected]>
felixfontein
approved these changes
Nov 23, 2025
Collaborator
Author
|
@felixfontein please note that this was not picked up by sanity checks before. Apparently, the validation looks for a literal |
Backport to stable-12: 💚 backport PR created✅ Backport PR branch: Backported as #11208 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
* onepassword_info: replace subprocess.Popen() with run_command() * add changelog frag * Update plugins/modules/onepassword_info.py Co-authored-by: Felix Fontein <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> (cherry picked from commit f2731e1)
felixfontein
removed
the
check-before-release
Collaborator
|
@russoz you might want to create an issue in ansible/ansible for that. |
felixfontein
added a commit
that referenced
this pull request
Nov 24, 2025
…bprocess.Popen() with run_command() (#11208) onepassword_info: replace subprocess.Popen() with run_command() (#11193) * onepassword_info: replace subprocess.Popen() with run_command() * add changelog frag * Update plugins/modules/onepassword_info.py --------- (cherry picked from commit f2731e1) Co-authored-by: Alexei Znamensky <[email protected]> Co-authored-by: Felix Fontein <[email protected]>
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The module was using
subprocess.Popen()to run an external command, whilst the recommended way is to useAnsibleModule.run_command().ISSUE TYPE
COMPONENT NAME
onepassword_info