Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix - Prevent passwordstore lookup to create subkey when create == false #9106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bugfix - Prevent passwordstore lookup to create subkey when create == false #9106

wants to merge 1 commit into from

Conversation

mluzarreta
Copy link
Contributor

SUMMARY

Prevent passwordstore lookup to create subkey when create == false
Fixes #9105

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

passwordstore lookup

@ansibullbot ansibullbot added bug This issue/PR relates to a bug lookup lookup plugin plugins plugin (any type) labels Nov 7, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch backport-9 Automatically create a backport for the stable-9 branch labels Nov 7, 2024
felixfontein
felixfontein reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added a first comment below.

changelogs/fragments/9106-passwordstore-fix-subkey-creation-even-when-create-==-false.yml Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

CC @mluzarreta

@mluzarreta
Copy link
Contributor Author

Suggestions applied @felixfontein

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Nov 16, 2024
@felixfontein
Copy link
Collaborator

@mluzarreta ping!

needs_info

@ansibullbot ansibullbot added the needs_info This issue requires further information. Please answer any outstanding questions label Dec 30, 2024
@ansibullbot
Copy link
Collaborator

@mluzarreta This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@mluzarreta mluzarreta force-pushed the main branch 2 times, most recently from 1165453 to 4f6fdf4 Compare February 4, 2025 11:07
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Feb 4, 2025
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Feb 4, 2025
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Feb 4, 2025
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Feb 4, 2025
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Feb 4, 2025
@ansibullbot ansibullbot removed the ci_verified Push fixes to PR branch to re-run CI label Feb 4, 2025
@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/lookup/passwordstore.py:588:22: E261: at least two spaces before inline comment

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/lookup/passwordstore.py:588:22: E261: at least two spaces before inline comment

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/lookup/passwordstore.py:588:22: E261: at least two spaces before inline comment

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

plugins/lookup/passwordstore.py:588:22: E261: at least two spaces before inline comment

click here for bot help

@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Feb 4, 2025
@mluzarreta
Copy link
Contributor Author

After struggling with the CI pipeline, this PR is ready to review again. As I said here, the initial PR contained a logic error which I have corrected. And sorry again for the delay 🙏

@ansibullbot ansibullbot removed the needs_info This issue requires further information. Please answer any outstanding questions label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-9 Automatically create a backport for the stable-9 branch backport-10 Automatically create a backport for the stable-10 branch bug This issue/PR relates to a bug check-before-release PR will be looked at again shortly before release and merged if possible. ci_verified Push fixes to PR branch to re-run CI lookup lookup plugin needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passwordstore lookup creates subkeys even when create==false and subkey does not exist
3 participants
@mluzarreta @felixfontein @ansibullbot