onepassword_doc: fix 1Password Connect support

[felixfontein]

SUMMARY

It seems that when #7116 and #7490 were merged, onepassword_doc.py ended up with the CLI parameters from OnePassCLIv2.get_raw() before 1Password Connect support was merged for onepassword.py. I'm not 100% sure all these parameters work with docs as well, but I think it's better to move adding these parameters to a separate function so it can be used from other derivatives of OnePassCLIv2.

@samdoran would be great if you could take a look :)

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

onepassword_doc

[ansibullbot]

cc @azenk
click here for bot help

[samdoran]

This is a good short term solution. Longer term, it would be nice to have a better and cleaner interface for specifying just the particular command that needs running instead of each plugin having to override get_raw.

Maybe it's as simple as making get_raw accept args. 🤔

I like the model of plugins for different types calling get_raw with different args and handling the processing of that output in that particular plugin. That seems to be a good separation of concerns.

[samdoran]

Another approach could be moving this to a new _run() method on the OnePassCLIv2 class.

[felixfontein]

This is a good short term solution. Longer term, it would be nice to have a better and cleaner interface for specifying just the particular command that needs running instead of each plugin having to override get_raw.

Indeed. This is only meant as a short-term solution that can be backported without a larger refactoring. There's more work to do - the shared code should also better be moved to plugin_utils or module_utils, etc.