Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users for namespace creation. #1899

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Allow users for namespace creation. #1899

merged 1 commit into from
Oct 12, 2023

Conversation

jctanner
Copy link
Collaborator

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Sep 25, 2023
@himdel himdel mentioned this pull request Sep 25, 2023
Merged
@jctanner jctanner removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Sep 25, 2023
@rochacbruno
Copy link
Member

This error on CI is related?

2023-09-25T15:29:27.7385689Z �[32mpulp_1 |�[0m pulp [fc674cd114a6440ea5dd045d7b6bb97c]: pulpcore.tasking.tasks:INFO: Task 018accf3-503d-75f9-8bb0-96b064e61e5a failed (AnsibleNamespaceMetadata() got unexpected keyword arguments: 'users')

@jctanner
Copy link
Collaborator Author

awaiting pulp/pulpcore#4479

@jctanner
Copy link
Collaborator Author

also awaiting pulp/pulp_ansible#1594

@jctanner jctanner force-pushed the V3_NAMESPACE_RBAC_ADD_USERS branch 2 times, most recently from 7ceb9b8 to ca66e49 Compare October 10, 2023 18:51
bmclaughlin
bmclaughlin previously requested changes Oct 11, 2023
View reviewed changes
galaxy_ng/app/access_control/mixins.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/v3/serializers/namespace.py Outdated Show resolved Hide resolved
@bmclaughlin
Copy link
Contributor

@jctanner Looks like the print statements have tried to avoid deletion, found a few more in:

galaxy_ng/app/access_control/fields.py
galaxy_ng/app/access_control/mixins.py
galaxy_ng/app/api/v3/serializers/namespace.py
galaxy_ng/app/api/v3/viewsets/namespace.py

@jctanner
Copy link
Collaborator Author

/retest

@jctanner jctanner merged commit 6c7b3f9 into ansible:master Oct 12, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himdel himdel himdel approved these changes

@rochacbruno rochacbruno Awaiting requested review from rochacbruno

@cutwater cutwater Awaiting requested review from cutwater

@appuk appuk Awaiting requested review from appuk

@ShaiahWren ShaiahWren Awaiting requested review from ShaiahWren

@bmclaughlin bmclaughlin Awaiting requested review from bmclaughlin

@jerabekjiri jerabekjiri Awaiting requested review from jerabekjiri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jctanner @rochacbruno @bmclaughlin @himdel @jerabekjiri