Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing comment in win_scan_packages #125

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix missing comment in win_scan_packages #125

merged 1 commit into from
Dec 15, 2023

Conversation

youtous
Copy link
Contributor

@youtous youtous commented Dec 15, 2023 •
edited
Loading

fixes a bug introduced by c0cd993#diff-b96b15b6317f28f23c0071daa9b0f176ead26855c8588c6167c30ba4ab8913aeL1 (missing comments)

Still don't know how it passes the CI

The target push CI is failing due to the missing comment:

error: cannot format collections/ansible_collections/demo/patching/plugins/modules/win_scan_packages.py: Cannot parse: 1:0: !/usr/bin/env python
Oh no! 💥 💔 💥
7 files left unchanged, 1 file failed to reformat.

@youtous youtous marked this pull request as ready for review December 15, 2023 16:04
@youtous youtous mentioned this pull request Dec 15, 2023
Merged
@youtous youtous requested a review from willtome December 15, 2023 16:09
@youtous youtous self-assigned this Dec 15, 2023
willtome
willtome approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@willtome willtome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willtome willtome merged commit 1832bb6 into main Dec 15, 2023
1 of 2 checks passed
@youtous youtous deleted the feature/fix_lint_python branch January 12, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willtome willtome willtome approved these changes

Assignees

@youtous youtous

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youtous @willtome