feat(CapsuleTabs): unified provision of custom prefixCls #6970
Conversation
dosubot
bot
added
the
size:M
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Summary of ChangesHello @EmilyyyLiu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求引入了一种统一的机制，用于跨组件自定义类前缀，并从 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
commit: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature for providing a custom prefixCls through ConfigProvider, enhancing component theming and style isolation. The implementation within ConfigProvider is robust, and CapsuleTabs has been updated to utilize this new capability. I've included a couple of review comments: one is a stylistic suggestion to improve import ordering for better code consistency, and the other is a more significant point about ensuring child components like ScrollMask also adopt the custom prefix to maintain a unified look and feel.
| <div className={`${classPrefix}-header`}> | ||
| <div className={prefixCls} ref={rootRef}> | ||
| <div className={`${prefixCls}-header`}> | ||
| <ScrollMask scrollTrackRef={tabListContainerRef} /> |
There was a problem hiding this comment.
The ScrollMask component does not seem to respect the custom prefixCls from ConfigProvider. The new test snapshots show that it still uses the default adm-scroll-mask class even when a custom prefix is provided. To ensure complete and consistent theming, child components should also use the provided prefix. Please consider updating ScrollMask to use getPrefixCls from useConfig, or pass the prefixCls to it if it supports that prop.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature #6970 +/- ##
===========================================
+ Coverage 92.95% 92.97% +0.01%
===========================================
Files 337 337
Lines 7368 7370 +2
Branches 1871 1835 -36
===========================================
+ Hits 6849 6852 +3
- Misses 483 510 +27
+ Partials 36 8 -28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EmilyyyLiu
force-pushed
the
feature-prefix-capsuleTabs
branch
from
4c43dc4 to
d6d8942
Compare
1 participant
统一添加自定义class 前缀
关联issue #6960