-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(CapsuleTabs): unified provision of custom prefixCls #6970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EmilyyyLiu
wants to merge
1
commit into
ant-design:feature
Choose a base branch
from
EmilyyyLiu:feature-prefix-capsuleTabs
base: feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
src/components/capsule-tabs/tests/__snapshots__/capsule-tabs.test.tsx.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`CapsuleTabs should apply prefixCls from ConfigProvider 1`] = ` | ||
| <div> | ||
| <div | ||
| class="config-prefix-capsule-tabs" | ||
| > | ||
| <div | ||
| class="config-prefix-capsule-tabs-header" | ||
| > | ||
| <div | ||
| class="adm-scroll-mask adm-scroll-mask-left" | ||
| style="opacity: 0;" | ||
| /> | ||
| <div | ||
| class="adm-scroll-mask adm-scroll-mask-right" | ||
| style="opacity: 0;" | ||
| /> | ||
| <div | ||
| class="config-prefix-capsule-tabs-tab-list" | ||
| > | ||
| <div | ||
| class="config-prefix-capsule-tabs-tab-wrapper" | ||
| > | ||
| <div | ||
| class="config-prefix-capsule-tabs-tab config-prefix-capsule-tabs-tab-active" | ||
| > | ||
| fruits | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| `; | ||
|
|
||
| exports[`CapsuleTabs should prioritize component prefixCls over ConfigProvider 1`] = ` | ||
| <div> | ||
| <div | ||
| class="component-prefix" | ||
| > | ||
| <div | ||
| class="component-prefix-header" | ||
| > | ||
| <div | ||
| class="adm-scroll-mask adm-scroll-mask-left" | ||
| style="opacity: 0;" | ||
| /> | ||
| <div | ||
| class="adm-scroll-mask adm-scroll-mask-right" | ||
| style="opacity: 0;" | ||
| /> | ||
| <div | ||
| class="component-prefix-tab-list" | ||
| > | ||
| <div | ||
| class="component-prefix-tab-wrapper" | ||
| > | ||
| <div | ||
| class="component-prefix-tab component-prefix-tab-active" | ||
| > | ||
| fruits | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ScrollMaskcomponent does not seem to respect the customprefixClsfromConfigProvider. The new test snapshots show that it still uses the defaultadm-scroll-maskclass even when a custom prefix is provided. To ensure complete and consistent theming, child components should also use the provided prefix. Please consider updatingScrollMaskto usegetPrefixClsfromuseConfig, or pass theprefixClsto it if it supports that prop.