reduces std::mem::size_of::<gossip::CrdsData>() #4391
+274
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadnouri
force-pushed
the
box-contact-info-cache
branch
2 times, most recently
from
974fd85 to
23038ae
Compare
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jan 10, 2025
anza-xyz#4391 adds type parameter to ContactInfo.cache but we don't want to expose that to outside of gossip crate. In order to encapsulate that change in gossip crate, this commit adds an alias for: Fn(&ContactInfo) -> R which can be used outside of gossip crate.
behzadnouri
added a commit
to behzadnouri/solana
that referenced
this pull request
Jan 10, 2025
anza-xyz#4391 adds type parameter to ContactInfo.cache but we don't want to expose that implementation detail to outside of the gossip crate. In order to encapsulate that change in gossip crate, this commit adds an alias for: Fn(&ContactInfo) -> R which can be used outside of the gossip crate.
behzadnouri
force-pushed
the
box-contact-info-cache
branch
from
23038ae to
03c984f
Compare
anza-xyz#4391 adds type parameter to gossip ContactInfo, but CrdsData::ContactInfo(_) can only be initialized with a specific type. In order to simplify the change and avoid verbosity, this commit implements From<ContactInfo> for CrdsData which allows to generically handle different types without changing the call sites.
anza-xyz#4391 adds type parameter to ContactInfo.cache but we don't want to expose that implementation detail to outside of the gossip crate. In order to encapsulate that change in gossip crate, this commit adds an alias for: Fn(&ContactInfo) -> R which can be used outside of the gossip crate.
We no longer use LegacyContactInfo and don't need to push updates over gossip.
Because ContactInfo.cache is huge, currently
std::mem::size_of::<gossip::CrdsData>()
stands at 560 bytes. However only a small % of entries in gossip CRDS
table are ContactInfo so this wastes a lot of memory.
In order to reduce the size of CrdsData enum, the commit adds type
parameter for ContactInfo.cache. For the ContactInfo stored in CRDS
table we use
ContactInfo.cache: Box<[SocketAddr; N]>
whereas outside gossip CRDS table we avoid Box<...> overhead by just
using the plain array:
ContactInfo.cache: [SocketAddr; N]
Doing so,
* std::mem::size_of::<gossip::CrdsData>() reduces from 560 bytes to
176 bytes.
* Accessing other fields of ContactInfo does not incur Box<...>
overhead.
* Outside gossip CRDS table, we avoid Box<...> overhead entirely.
behzadnouri
force-pushed
the
box-contact-info-cache
branch
from
03c984f to
c3cbfe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Because
ContactInfo.cacheis huge, currentlystands at 560 bytes. However only a small % of entries in gossip CRDS table are
ContactInfoso this wastes a lot of memory.Summary of Changes
In order to reduce the size of
CrdsDataenum, the commit adds type parameter forContactInfo.cache. For theContactInfostored in CRDS table we usewhereas outside gossip CRDS table we avoid
Box<...>overhead by just using the plain array:Doing so,
std::mem::size_of::<gossip::CrdsData>()reduces from 560 bytes to 176 bytes.ContactInfodoes not incurBox<...>overhead.Box<...>overhead entirely.