[Improvement][AMORO-3178]: Change the default configuration of values.yaml to improve user experience #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czy006
reviewed
Sep 6, 2024
| @@ -120,7 +120,7 @@ spark distribution package will be installed to here*/ -}} | |||
| {{- if .Values.plugin.metricReporters }} | |||
| {{- if .Values.plugin.metricReporters.prometheusExporter.enabled }} | |||
| - name: prometheus | |||
| containerPort: {{ .Values.plugin.metricReporters.prometheusExporter.port }} | |||
There was a problem hiding this comment.
if have anothor properties,not just only port.maybe can use map set of this config
There was a problem hiding this comment.
Thank you @czy006 , is this what you said?
prometheusExporter:
name: prometheus-exporter
enabled: true
port: 7001
properties:
port: {{ .Values.plugin.metricReporters.prometheusExporter.port }}
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
czy006
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3178
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Open the prometheus annotation in values and helm deployment will report an error.
Apply this patch and open prometheus annotation for helm deployment.
Documentation