Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][AMORO-3178]: Change the default configuration of values.yaml to improve user experience #3179

Merged
merged 4 commits into from
Oct 12, 2024
Merged

[Improvement][AMORO-3178]: Change the default configuration of values.yaml to improve user experience #3179

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b7fbbd
[Doc]Fix typo in managing-optimizers.md
Sep 4, 2024
48e3645
Merge branch 'apache:master' into master
upczsh Sep 6, 2024
78a4b8a
[AMORO-3178]Change the default configuration of values.yaml to improv…
Sep 6, 2024
da05e94
Merge branch 'master' into AMORO-3178
zhoujinsong Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/amoro/templates/_pod.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ spark distribution package will be installed to here*/ -}}
{{- if .Values.plugin.metricReporters }}
{{- if .Values.plugin.metricReporters.prometheusExporter.enabled }}
- name: prometheus
containerPort: {{ .Values.plugin.metricReporters.prometheusExporter.port }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if have anothor properties,not just only port.maybe can use map set of this config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @czy006 , is this what you said?

prometheusExporter:

  name: prometheus-exporter

  enabled: true

  port: 7001

  properties:

    port: {{ .Values.plugin.metricReporters.prometheusExporter.port }}

containerPort: {{ .Values.plugin.metricReporters.prometheusExporter.properties.port }}
{{- end -}}
{{- end -}}
{{- end -}}
Expand Down
8 changes: 4 additions & 4 deletions charts/amoro/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,12 @@ plugin:
# ## @param Enable or disable the Prometheus exporter
# ##
# enabled: true
# ## @param Prometheus port
# ##
# port: 7001
# ## @param Properties for the Prometheus exporter
# ##
# properties: ~
# properties:
# ## @param Prometheus port
# ##
# port: 7001

## Configure the ingress resource that allows you to access the
## Amoro installation. Set up the URL
Expand Down
Loading