Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Oct 24, 2025

Rationale for this change

r/tools/nixlibs.R assumes that arrow.repo ends with / but dev/tasks/macros.jinja uses arrow.repo without the end /.

What changes are included in this PR?

Add missing the end / and /libarrow sub directory.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Oct 24, 2025

@github-actions crossbow submit r-binary-packages

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Oct 24, 2025
@kou kou requested a review from thisisnic as a code owner October 24, 2025 02:03
@kou
Copy link
Member Author

kou commented Oct 24, 2025

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: 40cbd60

Submitted crossbow builds: ursacomputing/crossbow @ actions-58ba753772

Task Status
r-binary-packages GitHub Actions

@github-actions

This comment was marked as outdated.

@kou
Copy link
Member Author

kou commented Oct 24, 2025

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

Revision: 2d29854

Submitted crossbow builds: ursacomputing/crossbow @ actions-62e8c522cf

Task Status
r-binary-packages GitHub Actions

@kou
Copy link
Member Author

kou commented Oct 24, 2025

This is ready.

main case: #47929 (comment)
Release case: #47929 (comment)

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Oct 24, 2025
Copy link
Member

@amoeba amoeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help here @kou

@kou kou merged commit b000af1 into apache:main Oct 25, 2025
9 checks passed
@kou kou removed the awaiting merge Awaiting merge label Oct 25, 2025
@kou kou deleted the r-binary-path branch October 25, 2025 08:51
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b000af1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.

thisisnic pushed a commit that referenced this pull request Oct 25, 2025
### Rationale for this change

`r/tools/nixlibs.R` assumes that `arrow.repo` ends with `/` but `dev/tasks/macros.jinja` uses `arrow.repo` without the end `/`.

### What changes are included in this PR?

Add missing the end `/` and `/libarrow` sub directory.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: #47821

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants