Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35468] Update isEnableAutoAcknowledgeMessage config comment #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

geniusjoe
Copy link

Purpose of the change

Since we deleted shared and key-shared subscription type in pulsar source connector, I think it is better to remove these subscription type in isEnableAutoAcknowledgeMessage option comment to prevent misunderstanding.

Brief change log

update SourceConfiguration.java isEnableAutoAcknowledgeMessage comment.

Significant changes

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced

Copy link

boring-cyborg bot commented May 28, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@geniusjoe geniusjoe changed the title [FLINK-35468][Connectors/Pulsar] update isEnableAutoAcknowledgeMessage config comment [FLINK-35468] Update isEnableAutoAcknowledgeMessage config comment May 28, 2024
@syhily
Copy link
Contributor

syhily commented Jun 5, 2024

Shared subscription won't be introduced to Connector anymore. We will only use the Exclusive subscription because the Flink can handle the fallover logic internally. So the comments can be simplified.

@geniusjoe
Copy link
Author

Shared subscription won't be introduced to Connector anymore. We will only use the Exclusive subscription because the Flink can handle the fallover logic internally. So the comments can be simplified.

Thanks for your reply. Would you mind merge this pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants