Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-35468] Update isEnableAutoAcknowledgeMessage config comment #93

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FLINK-35468] Update isEnableAutoAcknowledgeMessage config comment #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions ...ar/src/main/java/org/apache/flink/connector/pulsar/source/config/SourceConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,12 @@ public long getPartitionDiscoveryIntervalMs() {
}

/**
* This is used for all subscription type. But the behavior may not be the same among them. If
* you don't enable the flink checkpoint, make sure this option is set to true.
* This is used for all subscription type.
* If you don't enable the flink checkpoint, please make sure this option is set to true.
* <p>
* {@link SubscriptionType#Failover} and {@link SubscriptionType#Exclusive} would perform
* an incremental acknowledgment in a fixed {@link #getAutoCommitCursorInterval}.
*
* <ul>
* <li>{@link SubscriptionType#Shared} and {@link SubscriptionType#Key_Shared} would
* immediately acknowledge the message after consuming it.
* <li>{@link SubscriptionType#Failover} and {@link SubscriptionType#Exclusive} would perform
* a incremental acknowledge in a fixed {@link #getAutoCommitCursorInterval}.
* </ul>
*/
public boolean isEnableAutoAcknowledgeMessage() {
return enableAutoAcknowledgeMessage;
Expand Down