GUACAMOLE-1846: Ensure successful builds on older GCC. #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-jumper
requested changes
Aug 29, 2023
There was a problem hiding this comment.
Please rebase against staging/1.5.4
If the reentrant rwlock implementation will become part of the public API within libguac, I recommend:
- Renaming the header to
rwlock.h - Renaming the structure to
guac_rwlockand related functions toguac_rwlock_* - Mirroring the naming and style of pthreads such that it's largely a drop-in replacement (and such that we have extra confirmation that our API aligns with well-established use).
jmuehlner
force-pushed
the
GUACAMOLE-1846-fix-struct-initializations
branch
2 times, most recently
from
84ec3e6
to
eb281c1
Compare
jmuehlner
force-pushed
the
GUACAMOLE-1846-fix-struct-initializations
branch
2 times, most recently
from
ad7e294
to
bf1abf4
Compare
Good suggestions. All done now. |
mike-jumper
requested changes
Aug 30, 2023
jmuehlner
force-pushed
the
GUACAMOLE-1846-fix-struct-initializations
branch
from
bf1abf4
to
2769e5f
Compare
mike-jumper
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some build issues introduced in #455.