fix: Add timeouts to go-redis client and ping on client creation #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
https://github.com/apache/kvrocks/blob/unstable/tests/gocase/tls/tls_test.go#L57 This case would not return the NOAUTH error since it sent the plain command to the TLS port. So it will return the connection closed by peer error. |
|
@git-hulk Yes, today I'll try to make some changes to the initial ones. |
torwig
force-pushed
the
set_test_client_timeouts
branch
2 times, most recently
from
bcaf3ce
to
4f30bfd
Compare
torwig
force-pushed
the
set_test_client_timeouts
branch
from
4f30bfd
to
91d6cae
Compare
|
Please, review. |
|
tisonkun
approved these changes
Jul 13, 2024
I suggest you can avoid using imperative sentences. It reads rudely. |
|
@tisonkun I'm sorry, I didn't want to sound rude or offensive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents failing tests on MacOS13 here: #2324