Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add timeouts to go-redis client and ping on client creation #2404

Merged
merged 2 commits into from
Jul 13, 2024
Merged

fix: Add timeouts to go-redis client and ping on client creation #2404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3f0c1b
Add timeouts to go-redis client and ping on client creation
torwig Jul 11, 2024
91d6cae
Refactor changes
torwig Jul 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tests/gocase/util/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,19 @@ func (s *KvrocksServer) NewClient() *redis.Client {
return s.NewClientWithOption(&redis.Options{})
}

func optionsWithTimeouts(options *redis.Options) *redis.Options {
options.DialTimeout = 30 * time.Second
options.ReadTimeout = 30 * time.Second
options.WriteTimeout = 30 * time.Second
return options
}

func (s *KvrocksServer) NewClientWithOption(options *redis.Options) *redis.Client {
if options.Addr == "" {
options.Addr = s.addr.String()
}
return redis.NewClient(options)

return redis.NewClient(optionsWithTimeouts(options))
}

func (s *KvrocksServer) NewTCPClient() *TCPClient {
Expand Down
Loading