Skip to content

Conversation

@Frawless
Copy link
Contributor

@Frawless Frawless commented Oct 8, 2025

This PR solves couple of corner cases that wasn't resolved as part of #3194 and also adds IT to cover it.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Tibor17
Copy link
Contributor

Tibor17 commented Oct 8, 2025

Including #3194
This is a never ending story because the Default reporter has wrong logic. I have some branch where this class should be implemented properly. The problem is that this class has an implicit logic with guesses and string description of test method execution...
These workarounds will never work properly because of the reasons I mentioned.
I will find the branch and we can work on it by then.
Maybe maybe ok for now, maybe, but I did not analyse all your commit.

Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just merge this and we are done
BTW build needs to be fixed
Thanks

@Frawless Frawless marked this pull request as ready for review November 3, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants